Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fix same-name (sub)groups interfering in Inspector #89631

Merged

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Mar 18, 2024

Clear (sub)group hashmaps when changing category.
@dalexeev dalexeev added this to the 4.3 milestone Mar 18, 2024
@dalexeev dalexeev requested a review from a team March 18, 2024 06:51
@dalexeev dalexeev added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 18, 2024
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also fixes issues in some built-in nodes, like Polygon2D which has its own texture section. Not sure if it was reported.

@kleonc
Copy link
Member

kleonc commented Mar 20, 2024

This also fixes issues in some built-in nodes, like Polygon2D which has its own texture section. Not sure if it was reported.

These seem the same: #83336, #83662.

@dalexeev
Copy link
Member Author

These seem the same: #83336, #83662.

Thanks, I tested and this PR does indeed fix these issues.

@akien-mga akien-mga closed this pull request by merging all changes into godotengine:master in 06abc86 Mar 24, 2024
akien-mga added a commit that referenced this pull request Mar 24, 2024
…nterfering

Editor: Fix same-name (sub)groups interfering in Inspector
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the editor-fix-inspector-groups-interfering branch March 24, 2024 04:21
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment